`disable_public_repos` not respected for Photon OS
sriramandev opened this issue · 1 comments
Environment
- Make target:
make build-node-ova-vsphere-photon-5 - Run using container image? (Y/N): No
- Vars file:
disable_public_repos=true
extra_repos=repos/xyz/artifactory-photon.repo
What steps did you take and what happened?
Run image builder with disable_public_repos set to true and extra_repos value set. This will help downstream systems to pull packages from internal repo rather than relying on public repos. However, changeset introduced fetch the latest gpg keys, may have broken this behaviour.
By the time setup role task Update the repos package to import the recent gpg keys gets called, the disabling (renaming of existing repo files) and addition of new repos is already complete. However, the task then seems to bring back the disabled repos tdnf update -y photon-repos --enablerepo=photon --refresh due to which rather than packages getting fetched from extra_repos, they will get fetched from the original (previously disabled) repos. This is not the desired intent.
What did you expect to happen?
Any disabled repo should not get enabled till actual enabling of the repos in sysprep role.
/kind bug
/assign