kubernetes-sigs/krew-index

[Question] When I add .krew.yaml to my project the github action run error

hantmac opened this issue · 7 comments

Hi, sorry to bother and I has a problem when adding the .krew.yaml to this krew plugin ,the github action run failed ,and I have add this plugin to krew index in this pr.
The error is as flows:
image

Do you have any idea to solve this problem? Than you very much!

cc: @rajatjindal any ideas?
I'm inclined to think that maybe the Actions job ran on a commit that actually didn't have the file?

upload-sha256sums-plugin: action does not have a checkout step, so it most likely dont have access to .krew file there.

just curious, is there any specific reason why you have implemented all steps of compiling/uploading etc as different steps instead of using something like go-releaser which takes care of most of these steps automatically?

upload-sha256sums-plugin: action does not have a checkout step, so it most likely dont have access to .krew file there.

just curious, is there any specific reason why you have implemented all steps of compiling/uploading etc as different steps instead of using something like go-releaser which takes care of most of these steps automatically?

Thank you very much, I forget to have a checkout step. But when I add the checkout step to release.yaml, I got another error.
image

The .krew.yaml file as flows:

apiVersion: krew.googlecontainertools.github.com/v1alpha2
kind: Plugin
metadata:
  name: kruise
spec:
  version: "{{ .TagName }}"
  platforms:
    - selector:
        matchLabels:
          os: linux
          arch: amd64
      {{addURIAndSha https://github.com/openkruise/kruise-tools/releases/download/{{ .TagName }}/kubectl-kruise-linux-amd64.tar.gz .TagName }}
      files:
        - from: "*/kubectl-kruise"
          to: "."
        - from: "*/LICENSE"
          to: "."
      bin: "kubectl-kruise"
    - selector:
        matchLabels:
          os: linux
          arch: arm64
      {{addURIAndSha https://github.com/openkruise/kruise-tools/releases/download/{{ .TagName }}/kubectl-kruise-linux-arm64.tar.gz .TagName }}
      files:
        - from: "*/kubectl-kruise"
          to: "."
        - from: "*/LICENSE"
          to: "."
      bin: "kubectl-kruise"
    - selector:
        matchLabels:
          os: darwin
          arch: amd64
      {{addURIAndSha https://github.com/openkruise/kruise-tools/releases/download/{{ .TagName }}/kubectl-kruise-darwin-amd64.tar.gz .TagName }}
      files:
        - from: "*/kubectl-kruise"
          to: "."
        - from: "*/LICENSE"
          to: "."
      bin: "kubectl-kruise"
    - selector:
        matchLabels:
          os: darwin
          arch: arm64
      {{addURIAndSha https://github.com/openkruise/kruise-tools/releases/download/{{ .TagName }}/kubectl-kruise-darwin-arm64.tar.gz .TagName }}
      files:
        - from: "*/kubectl-kruise"
          to: "."
        - from: "*/LICENSE"
          to: "."
      bin: "kubectl-kruise"
    - selector:
        matchLabels:
          os: windows
          arch: amd64
      {{addURIAndSha https://github.com/openkruise/kruise-tools/releases/download/{{ .TagName }}/kubectl-kruise-windows-amd64.tar.gz .TagName }}
      files:
        - from: "*/kubectl-kruise"
          to: "."
        - from: "*/LICENSE"
          to: "."
      bin: "kubectl-kruise"
  shortDescription: Easily handle OpenKruise workloads
  homepage: https://openkruise.io/
  description: |
    kubectl kruise is a kubectl plugin from the OpenKruise project. OpenKruise is an extended component suite for Kubernetes,
    which mainly focuses on application automations, such as deployment, upgrade, ops and avalibility protection.
    This plugin allows you to better handle, manage and maintain OpenKruise workloads.

https://rajatjindal.com/tools/krew-release-bot-helper - you can use this to generate the template file.

just enter "kruise" in input text and click generate.

also, i am still curious as to why you have all steps separately instead of using something like go-releaser. I am asking question again just to make sure its not missed in other discussion.

if it was a conscious decision on your side, it's perfectly fine.

thank you for using krew release bot.

@rajatjindal Thanks for your help! But I copy the yaml template from https://rajatjindal.com/tools/krew-release-bot-helper ,
image

and the yaml seems incorrect:
image

I got the same error as above. If you change the name of your plugin in the krew.yaml to one that exists, you won't see that error. I assumed it was because my plugin was "onboarded" yet.

The same error as rajatjindal/krew-release-bot#49, my .krew.yaml also has wrong format, I fix this in openkruise/kruise-tools#60