kubernetes-sigs/krew

download failures are interpreted as checksum mismatch

daniel-garcia opened this issue · 4 comments

daniel-garcia commented

The krew client ignores the status code. This results in misleading errors that show a checksum mismatch when in fact the artifact was never downloaded. According to the go documentation:

A non-2xx response doesn't cause an error

ahmetb commented

Agreed. Feel free to send a PR. I think we can check for non-200 codes as we expect the client to follow redirects and eventually hit an HTTP 200 OK.

  • 👍1
daniel-garcia commented

I have a pr here #820

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten