kubernetes-sigs/kubectl-validate

GitHub downloader is used even if local/hardcoded schemas are available

alexzielenski opened this issue · 5 comments

alexzielenski commented

As it stands now the GitHub builtins downloader unconditionally attempts to fetch the schemas. We should make it so this only happens if there are no other schemas available, to avoid quickly exhausting rate limit unnecessarily

clearnicki commented

If this is available to work on - I can help with this.

/assign

eddycharly commented

Isn't it fixed by #26 ?

alexzielenski commented

Isn't it fixed by #26 ?

Nope, this issue refers to the GitHub downloader always being unconditionally invoked by the Composite client. This can be fixed by creating a something like FallbackClient(HardcodedSchemas, FetchGitHubSchemas) that uses a fallback client if the primary client returned an error (like if the version is not supported by HardcodedSchemas).

clearnicki commented

@alexzielenski So #35 fixes this then? if so, I won't work on it.

/unassign

alexzielenski commented

apologies @clearnicki this issue became a blocker for setting up CI

/close