`kustomize edit add base` command adds dir as resource and not base

Question

`kustomize edit add base` command adds dir as resource and not base

reegnz opened this issue 5 years ago · 25 comments

Version

➜ kustomize version
Version: {KustomizeVersion:3.2.0 GitCommit:a3103f1e62ddb5b696daa3fd359bb6f2e8333b49 BuildDate:2019-09-20T10:10:22+02:00 GoOs:darwin GoArch:amd64}

Expected behavior

The command kustomize edit add base ../base should add a base to the kustomization file:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
bases:
- ../base

#Actual behavior
Running the kustomize edit add base ../base command results in this:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../base

How to reproduce

~
➜ mkdir test

~
➜ cd test

~/test
➜ mkdir base

~/test
➜ mkdir overlay

~/test
➜ cd base

~/test/base
➜ touch kustomization.yaml

~/test/base
➜ cd ..

~/test
➜ cd overlay

~/test/overlay
➜ touch kustomization.yaml

~/test/overlay
➜ kustomize edit add base ../base

~/test/overlay
➜ cat kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../base

pierluigilenoci commented 4 years ago

/reopen

Shell32-Natsu commented 4 years ago

/reopen

Answer 1 · 2019-09-24T15:39:04.000Z

Hi, see https://github.com/kubernetes-sigs/kustomize/blob/master/docs/v2.1.0.md#resources-expanded-bases-deprecated

Answer 2 · 2019-09-24T18:18:46.000Z

Would it be possible for kustomize to explicitly warn about these deprecation on stderr?

Answer 3 · 2019-10-17T02:51:27.000Z

Hi, see https://github.com/kubernetes-sigs/kustomize/blob/master/docs/v2.1.0.md#resources-expanded-bases-deprecated

Thanks for pointing that out!

The issue is, I'm trying to apply my newly created kustomization.yaml file, after the relocation, and I get:

$ kubectl apply -k .
error: rawResources failed to read Resources: Load from path ../base failed: '../base' must be a file (got d='/Users/bruno.medeiros/git/apps-portal/base')

It seems that kubectl is failing when there is a resource that is a directory, not a file.

kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T23:42:50Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.7-eks-e9b1d0", GitCommit:"e9b1d0551216e1e8ace5ee4ca50161df34325ec2", GitTreeState:"clean", BuildDate:"2019-09-21T08:33:01Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Do you know where can I report that?

Answer 4 · 2019-10-17T14:14:47.000Z

Another thing that is quite confusing with the deprecation is that only using resources breaks kubectl apply -k, since kubectl doesn't really know about that new feature yet...

So now if you edit kustomizations with the kustomize cli and not by hand they won't be compatible with kubectl.

eg.:

➜ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:27:17Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

➜ kubectl apply -k local
error: rawResources failed to read Resources: Load from path ../base failed: '../base' must be a file (got d='/Users/reegnz/example/base')

My kustomization in that case looks like this:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
  - ../base

When can one expect a feature to also drip downstream into kubectl?
Also how can I find out what features are in downstream kubectl and what I cannot use with kubectl apply -k?

Answer 5 · 2020-01-15T14:59:43.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Answer 6 · 2020-01-16T16:59:45.000Z

I am still getting this error.

$ kustomize edit add base ../../../bases/environment/staging-base

resources:
- Ingress.yml
- ../../../bases/microservice/services/account
- ../../../bases/environment/staging-base

Answer 7 · 2020-01-16T17:00:34.000Z

/remove-lifecycle stale

Answer 8 · 2020-03-30T15:53:31.000Z

@tomjohnburton @reegnz #1647 (comment) It worked for me as well using bases: instead of resources

working on windows docker for desktop

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Answer 9 · 2020-06-28T16:23:22.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Answer 10 · 2020-07-28T17:04:46.000Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Answer 11 · 2020-08-26T09:27:06.000Z

Another thing that is quite confusing with the deprecation is that only using resources breaks kubectl apply -k, since kubectl doesn't really know about that new feature yet...

So now if you edit kustomizations with the kustomize cli and not by hand they won't be compatible with kubectl.

eg.:
➜ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:27:17Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

➜ kubectl apply -k local
error: rawResources failed to read Resources: Load from path ../base failed: '../base' must be a file (got d='/Users/reegnz/example/base')
My kustomization in that case looks like this:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
  - ../base
When can one expect a feature to also drip downstream into kubectl?
Also how can I find out what features are in downstream kubectl and what I cannot use with kubectl apply -k?

hey are there any news?

Answer 12 · 2020-08-31T09:42:42.000Z

@pommelinho Didn't use kustomize for a while now, but checking the go.mod for kubectl:

https://github.com/kubernetes/kubectl/blob/18e781fa774127786b5a2092ed2dc0351dafdb87/go.mod#L46

Nope, it's still the same kustomize version that's used. :(

Answer 13 · 2020-09-30T09:54:42.000Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Answer 14 · 2020-09-30T09:54:49.000Z

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Answer 15 · 2020-09-30T12:44:19.000Z

/remove-lifecycle rotten

Answer 16 · 2020-09-30T12:44:36.000Z

@pierluigilenoci: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Answer 17 · 2020-09-30T17:47:26.000Z

@Shell32-Natsu: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Answer 18 · 2020-12-17T18:27:13.000Z

@Shell32-Natsu, Any news on this???? Still with a problem with kubectl... kustomize 3.8.7 can use resources to load bases but apparently not kubectl... When should this be changed?

$ kubectl apply -k env/xxxx-westus-ppd-dev
error: rawResources failed to read Resources: Load from path ../../base failed: '../../base' must be
   a file (got d='/Users/marcello.desales/dev/gitlab.xxx.com/xxx/yyy/k8s/helm/charts/agent/output/agent/templates/base')

This is the version from docker-for-desktop...

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:12:48Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.11", GitCommit:"3a3612132641768edd7f7e73d07772225817f630", GitTreeState:"clean", BuildDate:"2020-09-02T06:46:33Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

Answer 19 · 2021-01-18T13:19:17.000Z

Also experiencing this. Using kustomize build works, but kubectl kustomize gives me this error.

Answer 20 · 2021-01-19T17:52:30.000Z

We are in the last (hopefully) step to remove apimachinery from kustomize. #2506 is used to track this work.

Answer 21 · 2021-03-19T16:11:36.000Z

Seems like it is still an issue with kubectl 1.20.5

Using the multibase example from https://github.com/kubernetes-sigs/kustomize/tree/master/examples/multibases

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.5", GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"clean", BuildDate:"2021-03-18T01:10:43Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:04:18Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

$ git clone --depth 1 git@github.com:kubernetes-sigs/kustomize.git
$ cd kustomize/example/multibases
$ kubectl kustomize .
Error: rawResources failed to read Resources: Load from path dev failed: 'dev' must be a file (got d='/home/antonfr/Git/github/kustomize/examples/multibases/dev')

It still works without issue using kustomize build.

$ kustomize build .
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: myapp
  name: cluster-a-dev-myapp-pod
spec:
  containers:
  - image: nginx:1.7.9
    name: nginx
---
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: myapp
  name: cluster-a-prod-myapp-pod
spec:
  containers:
  - image: nginx:1.7.9
    name: nginx
---
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: myapp
  name: cluster-a-staging-myapp-pod
spec:
  containers:
  - image: nginx:1.7.9
    name: nginx

Answer 22 · 2021-06-17T16:38:11.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

Answer 23 · 2021-06-17T16:39:22.000Z

this is fixed in the most recent version of kubectl.