kubernetes-sigs/nfs-ganesha-server-and-external-provisioner

Please add support for pathPattern to match the nfs-subdir provisioner

Routhinator opened this issue · 7 comments

Routhinator commented

Hey, would love to see support for the path config to be able to be set for consistent volume naming/grouping on the filesystem as with the nfs-subdir provisioner.

pathPattern: "$${.PVC.namespace}/$${.PVC.name}"
kvaps commented

Currently nfs-server-provisioner creates directories according to PV name. eg:

/export/pvc-307c7fe3-ea0a-42b8-a0cd-ae145f155a25

I would not want to change this behavior. However we can consider adding symlinks with user friendly names like:

/export/by-pvc/<namespace>/<pvc-name> -> ../../pvc-307c7fe3-ea0a-42b8-a0cd-ae145f155a25

I think this can be done as part of #37 to have deterministic configuration and symlinks each new run.

  • ❤️3
johnnytolengo commented

Hello, will be fine to add a reference (as a prefix) of the PVC name in the NFS Folder.

Currently the PV is created as eg:
pvc-307c7fe3-ea0a-42b8-a0cd-ae145f155a25

let's say that my PVC is called: mytest

and what I would like to have in the NFS is something like:
mytest-pvc-307c7fe3-ea0a-42b8-a0cd-ae145f155a25

In that way I can recongnize which folder belongs to which deployed project.

Could you tell me which source file/function I have to modify?

Regards

johnnytolengo commented

Problem solved updated code on provision.go:

PVNamewithprefix := strings.ReplaceAll( string( strings.ToLower(options.PVC.Name) ) , " ", "" ) + "-" + options.PVName
now it's working as I expected :)

  • 👍1
k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.