Stop using docker-credential-gcloud for promotion (it is slow)
jonjohnsonjr opened this issue · 3 comments
What would you like to be added:
When calling google.{Walk,List}, you're already using gcrane.Keychain.
You should do the same thing when calling crane.Copy here.
Why is this needed:
The docker-credential-gcloud helper is slow:
$ time echo 'gcr.io' | docker-credential-gcloud get >/dev/null
real 0m0.756s
user 0m0.670s
sys 0m0.083s
Assuming this docker config file is used for the promo jobs, docker-credential-gcloud is invoked every time you call crane.Copy, whereas gcrane.Keychain will attempt to find application default credentials in the environment (which is much faster than invoking gcloud) or fall back to gcloud (once!) and cache the result across calls until it needs to be refreshed.
I think this was closed by #609
/close
@BenTheElder: Closing this issue.
In response to this:
I think this was closed by #609
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.