kubernetes-sigs/sig-storage-lib-external-provisioner

Error creating lock: endpoints lock is removed, migrate to endpointsleases

rajch opened this issue · 6 comments

rajch commented

On migrating from v6 to v8, my provisioner crashes with the following error:

F0720 16:59:52.441682    5606 controller.go:878] Error creating lock: endpoints lock is removed, migrate to endpointsleases

I can suppress it by disabling leader election, but would like to know how to solve the problem.

rajch commented

Found the problem. In the v8.0.0 tagged release, line 868 calls resourcelock.New with a hardcoded locktype of "endpoints", which is no longer supported. Here are the problem lines, in:
// https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/v8.0.0/controller/controller.go

	if ctrl.leaderElection {
		rl, err := resourcelock.New("endpoints",
			ctrl.leaderElectionNamespace,
			strings.Replace(ctrl.provisionerName, "/", "-", -1),
			ctrl.client.CoreV1(),
			nil,
			resourcelock.ResourceLockConfig{
				Identity:      ctrl.id,
				EventRecorder: ctrl.eventRecorder,
			})
		if err != nil {
			klog.Fatalf("Error creating lock: %v", err)
		}

This has been corrected in the master branch (specifically commit a4ce2c1), but a new release has not been made with the correction.

rajch commented

Could we have a new release, please?

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Will this be released officially anytime soon?

I've just released v9.0.0. Sorry about the long wait.

rajch commented

Thank you!