Build test container images for 1909
pjh opened this issue · 10 comments
Microsoft released Windows Server version 1909 last week, and the servercore:1909 base image is now available in MCR. I'd like to run the sig-windows e2e tests against 1909 - what does it take to rebuild these test containers for a new SAC version? I see BaseImages specified in Utils.ps1 - is it just a matter of adding a new line to that file, then having the right person invoke the right script from this repo?
@BCLAU could you advise and let me know if there's something I can do to help with this?
cc @adelina-t @yliaog @PatrickLang
Sounds like these issues are still blocking us from nailing down the process around the test images:
test images: Adds Windows Container images support (part 1)
test images: Adds E2E test image automated build
I know those discussions have been ongoing for a long time, thanks Claudiu for driving those. I'll review those again and see if there's any way to help out or get folks to decide/approve things.
Sorry for the late update, I was getting some things set up for this reply.
So, first of all, we've switched the building process from the one on this repo to the one you mentioned in your comment: kubernetes/kubernetes#76838 . The reason is simple, the plan is to have all the windows images be a part of the default registries and a part of the same building and publishing process, so when the images do get updated and bumped, we won't have to do the same here, reactively. Building from that PR / branch also helped in detecting and fixing issues in the building process as well.
The kubernetes/kubernetes#76838 PR has gone through quite a few reviews and iterations, but it is looking mergeable. Just waiting for LGTMs and approvals at this point. Considering that we'll probably have the Image Promotion bits in place too (kubernetes/kubernetes#84058), that could also cause delays for the test images Windows support PRs, as some infra googlers would probably have to take care of that part, and they're pretty overloaded, AFAIK.
Anyways, we've built and publishes the 1909 test images to the e2eteam registry, alongside the 1903 and 1809 images. Give it a try. :)
But if you're looking to build your own images, you can checkout this branch: kubernetes/kubernetes#77269 And follow the setup steps we've written the test/images/README.md file.
gcr.io/kubernetes-e2e-test-images/windows-nanoserver:v1 also needs to be updated with 1909
[Fail] [k8s.io] Container Runtime blackbox test when running a container with a new image [It] should be able to pull image from gcr.io [NodeConformance]
Error: failed to start container "image-pull-test": Error response from daemon: CreateComputeSystem image-pull-test: The container operating system does not match the host operating system.
(extra info: {"SystemType":"Container","Name":"image-pull-test","Owner":"docker","VolumePath":"\\?\Volume{dc57dfce-e19c-4d8b-b9a6-4699cfb617ff}","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\ProgramData\docker\windowsfilter\image-pull-test","Layers":[{"ID":"82384e92-e148-5c7c-84d4-22387d6238ed","Path":"C:\ProgramData\docker\windowsfilter\3a89926c4373fd99d86ac834dc997ebf719724d855f63ed1cdc2a838fbc4b1ae"},{"ID":"eaa8b7c1-405a-5e87-8db5-4931f45ce1bb","Path":"C:\ProgramData\docker\windowsfilter\da0c7ec5766e9d432835c7256a53686e4c65cbabae957723de897aba51ebaf6e"}],"ProcessorWeight":5000,"HostName":"image-pull-test095cbb61-db83-41d6-8e19-b33761e907ca","MappedDirectories":[{"HostPath":"c:\var\lib\kubelet\pods\55436943-dfa5-4165-a822-c5001ce01b92\volumes\kubernetes.io~secret\default-token-zl98t","ContainerPath":"c:\var\run\secrets\kubernetes.io\serviceaccount","ReadOnly":true,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false}],"HvPartition":false,"NetworkSharedContainerName":"69ea398247fc868722253207fe471a78358d3a3ff0a9d08dc8aa3a1d22efa3e7"})
gcr.io/authenticated-image-pulling/windows-nanoserver:v1 also needs 1909 build
[k8s.io] Container Runtime blackbox test when running a container with a new image
should be able to pull from private registry with secret [NodeConformance]
Pulling image "gcr.io/authenticated-image-pulling/windows-nanoserver:v1"
Error: failed to start container "image-pull-test": Error response from daemon: CreateComputeSystem image-pull-test: The container operating system does not match the host operating system.
/assign @claudiubelu
Claudiu, do you know what it would take to update the gcr.io/authenticated-image-pulling/windows-nanoserver:v1 container to be multi-arch? The e2eteam containers that you've updated are working well on 1909.
Hello. Indeed, the e2eteam registry contains images for 1809, 1903, and 1909. The mentioned test is failing because the image gcr.io/authenticated-image-pulling/windows-nanoserver:v1 only contains the nanoserver image for 1809. I have no access to that registry, so I can't push any updates there. We'll have to reach out to k8s-infra to get someone to update the manifest list to include the nanoserver image for all 3 versions. I'll try to reach out to someone, technically, it shouldn't take someone more than a few mintues to update that.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
We have tests passes on sig-windows dashboard for the mentioned test ([k8s.io] Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance]) that was failing: https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-1909-master and https://testgrid.k8s.io/sig-windows#gce-windows-1909-master
/close
@jsturtevant: Closing this issue.
In response to this:
We have tests passes on sig-windows dashboard for the mentioned test (
[k8s.io] Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance]) that was failing: https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-1909-master and https://testgrid.k8s.io/sig-windows#gce-windows-1909-master/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.