`kubectl wait` for prepulling GCE test containers takes too long to timeout
pjh opened this issue · 1 comments
pjh commented
The timeout behavior for kubectl wait is unintuitive - see kubernetes/kubectl#754 (comment). The result is that when one of our prepulled test containers fails to run, run-e2e.sh for GCE tests waits 90 minutes instead of 30 minutes before starting to run the e2e tests. The test run then times out at 120 minutes before most of the tests have been run.
An alternative approach might be something like we do in the GCE smoke-test, although surely that can be made a bit cleaner.
benmoss commented
We can wrap it with coreutils timeout, so we still get the optimistic case as faster than going back to sleep but the pessimistic case will be sane and only wait for as long as needed. I'll submit a PR.