ResourceQuota: Hard and Used are not ResourceList
AliMohammadiSoumee opened this issue · 6 comments
When I was using ResourceQuotaStatus.Hard, I found a mistake. Hard and Used are ResourceList, but actually they are not.
When you define Hard as a ResourceList, I can call methods of ResourceList on it, So I can call ResourceQuota.Status.Hard.CPU() for example, but it returns nothing because Hard contains Limits and Requests like ResourceRequirements type.
I know you define some constants for getting requests and limits from the Hard's ResourceList map(like ResourceRequestsCPU).
Can you explain why you didn't use ResourceRequirements as the type of the Hard or Used?
Can I fix it by changing types to ResourceRequirements?
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
you may have better luck filing issue on the main kubernetes repository. This is just a mirror repo and it is not monitored for issues. See https://github.com/kubernetes/api#things-you-should-not-do
/close
@SergeyKanzhelev: Closing this issue.
In response to this:
you may have better luck filing issue on the main kubernetes repository. This is just a mirror repo and it is not monitored for issues. See https://github.com/kubernetes/api#things-you-should-not-do
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.