Azure disk in-tree to CSI driver migration

Question

Azure disk in-tree to CSI driver migration

davidz627 opened this issue 5 years ago · 70 comments

davidz627 commented 5 years ago

Enhancement Description

One-line enhancement description (can be used as a release note): Migrate the internals of in-tree Azure Disk Plugin to call out to the Azure Disk CSI Driver respectively while maintaining the original API
Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md
Primary contact (assignee): @andyzhangx
Responsible SIGs: sig-storage
Enhancement target (which target equals to which milestone):
- Alpha release: 1.15
- Beta release: 1.19
- Stable release target (x.y): v1.24

Parent enhancement: #625
Public Migration testing CI: LINK

TODO

Replace design/KEP with specific one if needed
Link public migration testing CI

andyzhangx commented 3 years ago

/close

Answer 1 · 2020-01-21T23:54:30.000Z

/sig storage

Answer 2 · 2020-01-22T07:09:30.000Z

azure disk & file won't go BETA on 1.18 since there is dependency on csi windows, if we go beta, that means all requests for built-in driver would be redirected to csi driver, while csi driver does not work on Windows, that will break azure disk & file driver on Windows

Answer 3 · 2020-01-22T07:09:51.000Z

/sig cloud-provider
/area provider/azure

Answer 4 · 2020-01-22T07:10:17.000Z

@davidz627 thanks for driving this

Answer 5 · 2020-01-22T08:07:31.000Z

/assign @andyzhangx

Answer 6 · 2020-01-22T19:29:09.000Z

@andyzhangx feel free to edit description, you are the owner of this issue now :)

Answer 7 · 2020-01-22T21:45:36.000Z

@feiskyer @andyzhangx should we track this for 1.18? It looks like your description indicates you plan to go beta on this, but the linked issue indicates you're blocked by some windows things?

Answer 8 · 2020-01-23T01:26:03.000Z

/milestone v1.19

Answer 9 · 2020-01-23T01:37:22.000Z

Thanks @feiskyer!

Answer 10 · 2020-04-22T01:59:26.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Answer 11 · 2020-04-27T20:25:55.000Z

/remove-lifecycle stale

Answer 12 · 2020-04-28T23:09:34.000Z

Hi @feiskyer -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate to Beta in 1.19?

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

Answer 13 · 2020-05-08T12:44:01.000Z

Azure disk & azure file migration would go beta in 1.19, here is the PR: kubernetes/kubernetes#90896

Answer 14 · 2020-05-11T17:29:22.000Z

Hi @andyzhangx 👋 , thank you for the update. I've updated the tracking sheet accordingly.

Let us know if there are any other PR's that you would want to track for this release.

Answer 15 · 2020-05-11T17:30:04.000Z

/stage beta
/milestone v1.19

Answer 16 · 2020-05-21T22:07:26.000Z

Hi @andyzhangx - I am Savitha, 1.19 Docs lead. Does this enhancement work planned for 1.19 require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Answer 17 · 2020-05-25T16:31:35.000Z

Hi @andyzhangx -- Do you have any implementation other than kubernetes/kubernetes#90896? If yes, can you please link them here - k/k or otherwise? 🙂

The current release schedule is:

~~Monday, April 13: Week 1 - Release cycle begins~~
~~Tuesday, May 19: Week 6 - Enhancements Freeze~~
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

Answer 18 · 2020-06-01T12:15:14.000Z

Hi @andyzhangx - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same so that the tracking sheet can be updated accordingly. Thanks!

Answer 19 · 2020-06-01T13:06:19.000Z

Hi @andyzhangx - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same so that the tracking sheet can be updated accordingly. Thanks!

@savitharaghunathan here is the PR, we are going to go beta for azure disk migration first, and azure file migration keeps alpha in 1.19, thanks.

Answer 20 · 2020-06-01T13:37:43.000Z

Hi @andyzhangx -- pinging back again to see if there are any implementation PRs other than kubernetes/kubernetes#90896 ? Thanks. 🙂

Answer 21 · 2020-06-01T13:41:09.000Z

Hi @andyzhangx -- pinging back again to see if there are any implementation PRs other than kubernetes/kubernetes#90896 ? Thanks. 🙂

no, thanks @palnabarun

Answer 22 · 2020-06-01T13:50:47.000Z

Thanks @andyzhangx 👍

Answer 23 · 2020-06-09T11:37:34.000Z

Update: we don't need such a docs PR for this issue update.

Answer 24 · 2020-06-18T17:50:34.000Z

Hi @andyzhangx -- just wanted to check in about the progress of the enhancement. From the above comments, can we assume that kubernetes/kubernetes#90896 is the only implementation PR and the graduation requirements for this enhancement is complete?

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. 🙂

The revised release schedule is:

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

Answer 25 · 2020-07-01T14:11:24.000Z

From the above comments, can we assume that kubernetes/kubernetes#90896 is the only implementation PR and the graduation requirements for this enhancement is complete?

Hi @andyzhangx 👋, can you please update regarding the above? 🙂

Answer 26 · 2020-07-01T14:24:35.000Z

Hi @andyzhangx -- just wanted to check in about the progress of the enhancement. From the above comments, can we assume that kubernetes/kubernetes#90896 is the only implementation PR and the graduation requirements for this enhancement is complete?

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. 🙂

The revised release schedule is:

Thursday, July 9th: Week 13 - Code Freeze

Thursday, July 16th: Week 14 - Docs must be completed and reviewed

Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

@palnabarun Azure disk in-tree to CSI driver migration go beta in v1.19.0(with PR kubernetes/kubernetes#90896), and Azure file in-tree to CSI driver migration remains alpha. Thanks.

Answer 27 · 2020-07-06T10:07:40.000Z

Hi @andyzhangx 👋, thank you for the update. Usually, the enhancement graduates either completely or stays in the same state.

Since this enhancement involves two distinct functionalities, I am thinking if a new enhancement should be created tracking the Azure file in-tree to CSI driver migration. This enhancement can be reworded to involve just Azure disk in-tree to CSI driver migration and can graduate to Beta in 1.19. The new enhancement concerning Azure file in-tree to CSI driver migration can graduate in later releases.

Please let me know what do you think about it.

Thank you. 🙂

Answer 28 · 2020-07-06T13:16:37.000Z

Hi @andyzhangx 👋, thank you for the update. Usually, the enhancement graduates either completely or stays in the same state.

Since this enhancement involves two distinct functionalities, I am thinking if a new enhancement should be created tracking the Azure file in-tree to CSI driver migration. This enhancement can be reworded to involve just Azure disk in-tree to CSI driver migration and can graduate to Beta in 1.19. The new enhancement concerning Azure file in-tree to CSI driver migration can graduate in later releases.

Please let me know what do you think about it.

Thank you. 🙂

@palnabarun agree, I have created a new issue to track Azure File CSI driver migration: #1885
@davidz627 could you reset the title to Azure disk in-tree to CSI driver migration? thanks.

Answer 29 · 2020-07-06T14:54:36.000Z

@andyzhangx -- Thanks for creating #1885 👍

Answer 30 · 2020-07-06T14:54:56.000Z

/retitle Azure disk in-tree to CSI driver migration

Answer 31 · 2020-07-06T14:55:43.000Z

@andyzhangx -- I have also retitled this issue and updated the issue description.

Answer 32 · 2020-08-25T01:09:04.000Z

/milestone clear

Answer 33 · 2020-08-25T01:09:13.000Z

/milestone v1.20

Answer 34 · 2020-08-25T01:22:14.000Z

it's already beta in v1.19

Answer 35 · 2020-09-13T22:23:36.000Z

Hi @andyzhangx

Enhancements Lead here. I have updated the description to reflect beta in 1.19. Any plans for this in 1.20?

Thanks!
Kirsten

Answer 36 · 2020-09-25T00:07:02.000Z

Hi again @andyzhangx

Just wanted to circle back and check to see if you're planning to graduate to stable in 1.20?

As an FYI, 1.20 Enhancements Freeze is October 6th.

I do note that this KEP is using the old template, if you could update to the new one that would be great. See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

I also note that the implementation history of the KEP needs to be updated.

Thanks!
Kirsten

Answer 37 · 2020-09-27T19:36:36.000Z

@andyzhangx @craiglpeters

I noticed that a 1.20 milestone was added to this, but was that in error, it doesn't seem that this would be moving to GA in 1.20? Can someone please clarify?

Answer 38 · 2020-10-05T22:05:27.000Z

Spoke to @msau42 and this will be remaining in beta for 1.20

/milestone clear

Answer 39 · 2021-01-03T22:13:51.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Answer 40 · 2021-01-04T00:53:22.000Z

/remove-lifecycle stale

Answer 41 · 2021-04-04T01:28:07.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

Answer 42 · 2021-05-04T01:35:11.000Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

Answer 43 · 2021-05-04T01:43:25.000Z

/remove-lifecycle rotten

Answer 44 · 2021-06-03T10:01:26.000Z

@andyzhangx should we move this to GA now?

Answer 45 · 2021-09-01T10:17:25.000Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Answer 46 · 2021-10-01T10:52:57.000Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Answer 47 · 2021-10-31T11:08:04.000Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Answer 48 · 2021-10-31T11:08:21.000Z

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Answer 49 · 2021-11-02T01:16:39.000Z

/reopen
/remove-lifecycle rotten

Answer 50 · 2021-11-02T01:16:57.000Z

@msau42: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Answer 51 · 2021-11-15T19:50:41.000Z

/milestone v1.23
An exception request was filed on 11/12/21 for the 1.23 Enhancements Freeze. The exception request was approved on 11/13/21
Please update the kep.yaml to reflect the latest milestone (1.23) and have the PR to update the kep.yaml and any open k/k PRs approved by 18:00 PST on November 16th
Linked k/k PR: kubernetes/kubernetes#104670

This enhancement does not graduate phases for 1.23, it remains in beta. The default behavior changes from off to on in 1.23

Answer 52 · 2021-11-15T21:55:12.000Z

KEP milestone update: #3049
Docs: kubernetes/website#30495

Answer 53 · 2022-01-06T17:09:43.000Z

/milestone v1.24

Answer 54 · 2022-01-16T19:21:30.000Z

/stage stable
/tracked yes

Answer 55 · 2022-01-16T19:30:51.000Z

Hi @andyzhangx! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting stable for 1.24.

Here’s where this enhancement currently stands:

Updated KEP file using the latest template has been merged into the k/enhancements repo. - PENDING #3109
KEP status is marked as implementable for latest-milestone: 1.24 - PENDING #3109
KEP has a test plan section filled out. - COMPLETE IN PARENT KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration
KEP has up to date graduation criteria. - COMPLETE IN PARENT KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration
KEP has a production readiness review that has been completed and merged into k/enhancements. - PENDING #3109

The status of this enhancement is at risk. Thanks!

Answer 56 · 2022-01-18T01:34:29.000Z

@davidz627 could you mark the target as 1.25 as GA in this issue? Thanks.

Answer 57 · 2022-01-18T01:35:55.000Z

@davidz627 BTW, you will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

Answer 58 · 2022-01-19T21:20:59.000Z

@andyzhangx can you confirm if you want to target GA in 1.24 or 1.25?

Answer 59 · 2022-01-20T01:47:18.000Z

@msau42 Azure disk target GA in 1.24

Answer 60 · 2022-01-20T20:08:02.000Z

You will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@andyzhangx I think it's better if you submit the PR after you have finished all the necessary testing and other GA requirements.

Answer 61 · 2022-01-21T02:48:51.000Z

You will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@andyzhangx I think it's better if you submit the PR after you have finished all the necessary testing and other GA requirements.

@msau42 here is the PR: kubernetes/kubernetes#107681

Answer 62 · 2022-01-27T02:09:00.000Z

I see that #3109 has been merged. I have updated the status to tracked for enhancement freeze.

Answer 63 · 2022-02-13T18:45:35.000Z

Hi @andyzhangx, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

Answer 64 · 2022-03-22T02:26:41.000Z

Hi @andyzhangx

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like just k/k#107681 needs to be merged. Let me know if there are any other PRs that we should be tracking for 1.24 code freeze.

Let me know if you have any questions.

Answer 65 · 2022-03-29T02:49:02.000Z

Friendly reminder to try to merge k/k#107681 before code freeze at 01:00 UTC Wednesday 30th March 2022.

Answer 66 · 2022-04-02T13:59:42.000Z

kubernetes/kubernetes#107681 is already merged, so we could close this issue now? @msau42

Answer 67 · 2022-05-09T14:03:31.000Z

Hello @andyzhangx @davidz627 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

Answer 68 · 2022-05-09T14:10:37.000Z

thanks, I have worked out a PR: #3300

Answer 69 · 2022-05-09T14:11:03.000Z

@andyzhangx: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.