Allow labels feature.node.kubernetes.io by cloud provider

[sergelogvinov]

Hello

Can we add capability to set feature.node.kubernetes.io/<feature-name> by cloud provider?
I believe they was designed for that https://kubernetes.io/docs/reference/labels-annotations-taints/#feature-node-kubernetes-io

And probably node.cloudprovider.kubernetes.io/

@mmerkes
Thank you.

kubernetes/staging/src/k8s.io/cloud-provider/controllers/node/node_controller.go

Lines 545 to 558 in eeb42fa

	if len(instanceMeta.AdditionalLabels) > 0 {
	klog.V(2).Infof("Adding additional node label(s) from cloud provider: %v", instanceMeta.AdditionalLabels)
	nodeModifiers = append(nodeModifiers, func(n *v1.Node) {
	if n.Labels == nil {
	n.Labels = map[string]string{}
	}
	k8sNamespaceRegex := regexp.MustCompile("(kubernetes|k8s).io/")
	for k, v := range instanceMeta.AdditionalLabels {
	// Cloud provider should not be using kubernetes namespaces in labels
	if isK8sNamespace := k8sNamespaceRegex.MatchString(k); isK8sNamespace {
	klog.Warningf("Discarding node label %s with kubernetes namespace", k)
	continue

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sergelogvinov]

/sig cloud-provider