scheduler_perf: Allow each test case to specify its timeout
utam0k opened this issue · 7 comments
/kind feature
/sig scheduling
what
Allow each test case to specify its timeout. Now, it is specified 30 minutes as hard coding.
kubernetes/test/integration/scheduler_perf/scheduler_perf.go
Lines 759 to 760 in 99a8a6f
why
I admit that 30 minutes is enough for the default scheduler with the in-tree scheduler plugins, but scheduler_perf is also helpful for other schedulers with outside scheduler plugins. In that case, more than 30 minutes might be required to complete a test case.
This issue is currently awaiting triage.
If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@kubernetes/sig-scheduling-approvers I'd be happy to contribute to this issue if it is acceptable.
User case is first, do you have any real case here.
Agree with @kerthcet. If you want to define a test case which takes more than 30 mins to finish, it feels like that's something undesired.
Additionally to say, even if there's a usecase (let's say using ~1 hour) actually, could we just extend the global timeout to 1 hour? I don't see any necessity of per-test timeout.