Remove drive letter during formatAndMount causes subPath evalSymlink issue

Question

Remove drive letter during formatAndMount causes subPath evalSymlink issue

jingxu97 opened this issue 5 years ago · 19 comments

In PR #166, we remove driver letter during formatAndMount due to the issue of driver letter runout. Now, volume mount will create symlink from volumeId to a path. e.g.,
mklink testlink \?\Volume{2f230ace-0000-0000-0000-010000000000}\

However, in subPath setup, https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/util/subpath/subpath_windows.go#L53
filepath.EvalSymlinks(hostPath)
will fail with error: too many links.

We need to find another way to evaluate the symlink when driver letter is not assigned.

Answer 1 · 2020-06-17T00:57:33.000Z

actually I am the author of that code finalSubPath, err := filepath.EvalSymlinks(hostPath), can we skip this too many links directly in the code if hostPath starts with \, this should be bug in filepath.EvalSymlinks

Is that windows specific code, or will that open a hole in Linux symlink checking?

it's only in windows specific code

Answer 2 · 2020-06-17T01:07:25.000Z

@andyzhangx you mean skip this EvalSymlinks check or if the error is "too many links", we ignore the error?

Answer 3 · 2020-06-17T01:12:50.000Z

Is that windows specific code, or will that open a hole in Linux symlink checking?

Answer 4 · 2020-06-17T01:12:53.000Z

if the error is "too many links"

if the error is "too many links" error and if hostPath starts with \, ignore error (only in Windows code)

Answer 5 · 2020-06-18T17:24:42.000Z

@andyzhangx but that means we don't check symlink for subpath in this case. Then it will open up the security issue that was fixed by this symlink check, I think.

Answer 6 · 2020-06-18T17:25:31.000Z

Is that windows specific code, or will that open a hole in Linux symlink checking?

This is mount_windows.go code. So the changes here will not affect linux symlink checking.

Answer 7 · 2020-07-22T17:24:54.000Z

Re Go filepath.EvalSymlinks, see golang/go#40180

It is probably not a good solution to any problem, except to show an administrator where a certain path leads at this moment.

Answer 8 · 2020-10-20T17:49:59.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Answer 9 · 2020-10-20T18:01:28.000Z

/remove-lifecycle stale

We made a workaround to solve this, but still want to investigate more to find a better way..

Answer 10 · 2021-01-18T19:01:01.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Answer 11 · 2021-02-17T19:47:00.000Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

Answer 12 · 2021-02-17T21:37:50.000Z

/remove-lifecycle rotten

Answer 13 · 2021-05-18T22:15:22.000Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

Answer 14 · 2021-06-17T22:33:10.000Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

Answer 15 · 2021-06-18T00:15:06.000Z

/remove-lifecycle rotten

Answer 16 · 2021-09-16T00:43:05.000Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Answer 17 · 2021-10-16T01:28:41.000Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Answer 18 · 2021-11-15T01:39:14.000Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Answer 19 · 2021-11-15T01:39:33.000Z

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.