[build] The `go.sum` is affected by running `make test` locally
enp0s3 opened this issue · 4 comments
/kind bug
What happened:
When running make test locally the go.sum file is being changed. OTOH when running make sanity this file is being reverted back to its commited state. With that said, a developer can by mistake commit changes done by make test
assuming that the go.sum was changed correctly. The make sanity on the CI will fail
What you expected to happen:
all make targets to produce consistent and reproducible artifacts.
How to reproduce it (as minimally and precisely as possible):
Run make test in your local environment
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.