kubevirt/hyperconverged-cluster-operator

[unit-tests] improve coverage for the upgradePatches logic

enp0s3 opened this issue · 4 comments

enp0s3 commented

/kind enhancement

What happened:
With the cuurent unit testing the JSON operations in upgradePatches package, the default HCO that is taken is
the one from the current main branch. I Would suggest to improve the coverage by treating the semver ranges of
HCO versions, and fetch the HCO default per each such version, then test the JSON operations on that version and
observe the expected vs actual object.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.