kudago/smart-app-banner

1.3.1 has breaking changes

sgtpepper43 opened this issue · 2 comments

sgtpepper43 commented

You moved your css files, which is a very, very big breaking change. You need to bump to 2.0.0 if you're going to move public files people have to reference. Your docs even say to reference the css file like so:

<link rel="stylesheet" href="node_modules/smart-app-banner/smart-app-banner.css" type="text/css" media="screen">

So everybody's been referencing it there, not in dist, so this is a breaking change, not a "patch".

sgtpepper43 commented

I'm still pissed about this but it's been two years with no response from the maintainer.

dy commented

Don't be pissed off. Fixed.
There is no single maintainer for this package.