kudulab/docker-ansible-dojo

Test that make is installed

mm689 opened this issue · 4 comments

mm689 commented

Make is part of the image, should be validated in tests.

xmik commented

Make is neither part of the specification of this image, nor it is installed explicitly. Do you @mm689 know which line of the Dockerfile installs it? It is possible that it is installed only to satisfy Ansible runtime dependencies, not as a separate tool for end user to use. If we wanted to test for all the things installed in this image, we should also test for python python-yaml sudo curl gcc python-pip python-dev libffi-dev libssl-dev and similar.

What do you think @mm689 ?

tomzo commented

@xmik we knew all that. The point is to add make as part of the specification because we use it in some project.

xmik commented

Ok, I'll do that.

xmik commented

Done, released in 1.3.0