kulttuuri/DiscordNotifications

Ghost notifications from edits not actually saved

Closed this issue · 5 comments

ciencia commented

I've seen another ghost notification appear again. The notification seems legit, except:

  • The diff is from the last edit of the page, that was done months ago
  • The user name (in this case) is an IP address, that looking at contributions has no contributions
  • The edit summary is not present in the comment table. The edit has never existed!

Since the actor is an IP address, this time I've looked at the webserver access logs, and I've discovered an edit attempt for that IP address, that apparently hasn't been saved.

I have ConfirmEdit installed, and I suspect the IP address has posted a link that triggered the captcha, it blocked the edit, but DiscordNotifications received it anyway.

I have ConfirmEdit loaded before DiscordNotifications in LocalSettings, which apparently should fire before, unless they're using different hooks that trigger at different times...

prodigion commented

I also just had this issue. I don't believe I've ever seen this happen before. I'm on MW 1.35.3 with DiscordNotifications 1.1.4.

kulttuuri commented

Still happening?

prodigion commented

Yes, I can trigger it with a null edit (https://en.wikipedia.org/wiki/Wikipedia:Purge#Null_edit).

kulttuuri commented

Sorry for taking so long to respond to this – This should now be fixed in the latest commit. Can you check it out @prodigion?

prodigion commented

After deploying this on MW 1.35.5, I'm no longer able to reproduce the issue.