kundajelab/simdna

LoadedEncodeMotifs error in python3

krrome opened this issue · 4 comments

Loading of encode motifs with LoadedEncodeMotifs(ENCODE_MOTIFS_PATH, pseudocountProb=0.001) does not work in python3. Conversion of read lines to unicode solves the problem, but will break functionality in python2.7. As a quick fix for me I just added "line = line.decode("utf-8")" here:

process_line(line, i, ignore_input_title,

Just ran into this in deepchem/deepchem#1008. Would you folks be amenable to a PR adding this fix in?

Yes, sorry for not getting to it earlier. Are you guys planning to add the PR or should I? Also, you're using version 0.3 right?

Fix is included in this PR
#5

Cool, just merged.