kurin/blazer

Blazer should test and handle all tcp/http/tls connection issues.

kurin opened this issue · 5 comments

kurin commented

A lot of this is caught (I think) here https://github.com/kurin/blazer/blob/master/base/base.go#L388 but eyeballing it I didn't build in the same protection here https://github.com/kurin/blazer/blob/master/base/base.go#L1076

kurin commented

This fragile channel nonsense could stand to be stuffed into a single function.

kurin commented

In fact none of it needs to exist now that the http package supports contexts.

someone1 commented

maybe i missed it but did you actually call WithContext anywhere when making the request? Doesn't appear so?

kurin commented

Haha, whoops, good catch.

I thought I had a test for this exact thing; I guess I need one.