kurtbrose/pyjks

Proposal: Add embedded type hints

Opened this issue · 1 comments

intgr commented

I want to add type hints for the pyjks package. Roughly there are two ways I could achieve this:

  1. Contribute embedded type hints to upstream pyjks project directly (e.g. change def xor_bytearrays(a, b): -> def xor_bytearrays(a: bytearray, b: bytearray) -> bytearray:)
  2. Create a separate types/stubs project such as types-pyjks. Would make most sense to create it under the typeshed umbrella, which already maintains lots of stubs packages.

Generally the Python community prefers approach (1), hence I'm trying to gauge the interest. I've noticed that the pyjks project has been static for several years now. Are there still maintainers here who could review such a PR and release a new version?

Approach (1) would also mean removing support for older Python versions, as type hints were introduced in 3.5 but are more annoying in the initial Python versions. Python 3.7 is EOL since 2 months ago and I think we should support version range 3.8 ... 3.12.

Alternatively, if maintainers aren't interested in this, I will pursue (2).

intgr commented

I have taken approach (2) and opened a pull request to add pyjks type hints to typeshed instead: