kuu/hls-parser

License

ajorg-aws opened this issue · 4 comments

ajorg-aws commented

Hello. I see "license": "MIT", in package.json but I can't find any actual license file in the project. The one condition in the MIT License is:

The above copyright notice and this permission notice (including the next paragraph) shall be included in all copies or substantial portions of the Software.

But there are no copyright notices in the project, and the permission notice is not included in any portion of the software.

kuu commented

Thanks @ajorg-aws for pointing this out. I added a LICENSE file. #78
Do you think it's ok to just add the file to this repository and omit it from the npm package and the compiled JS file?
I just wanted to make those files light.

ajorg-aws commented

Just adding it to the repo does help a lot.
What we do to keep the npm package small is use something like this in a comment in the JavaScript:

/*! Copyright <your name>. SPDX-License-Identifier: MIT */

The /*! keeps it from being stripped out by webpack (unless you strip it out anyway) and the license identifier refers folks to https://spdx.org/licenses/MIT.html

  • 👍1
kuu commented

Thanks for the tip. 👍 I added the line #79
I found that webpack generates a .min.js.LICENSE.txt file which is referred from .min.js file.
Seems like in that way I can write a longer statement.

  • 👍1
ajorg-aws commented

Thanks!