Uncaught ReferenceError: shell is not defined
joannebasa opened this issue · 19 comments
[Enter steps to reproduce:]
- ...
- ...
Atom: 1.22.1 x64
Electron: 1.6.15
OS: Mac OS X 10.13.1
Thrown From: ide-ruby package 0.1.6
Stack Trace
Uncaught ReferenceError: shell is not defined
At /Users/Joanne Basa/.atom/packages/ide-ruby/src/main.js:52
ReferenceError: shell is not defined
at NotificationElement.onDidClick (/packages/ide-ruby/src/main.js:52:60)
at HTMLAnchorElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/notifications/lib/notification-element.js:135:48)
Commands
-0:05.7.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-when-scrolling)
Non-Core Packages
ask-stack 2.2.0
atom-autocomplete-php 0.25.6
atom-beautify 0.30.9
atom-html-templates 0.1.3
atom-ide-ui 0.6.0
auto-update-packages 1.0.1
autoclose-html 0.23.0
autocomplete-html-entities 0.2.0
autocomplete-paths 2.12.1
autoupdate-packages 1.3.1
color-picker 2.2.5
file-icons 2.1.14
git-plus 7.10.0
git-time-machine 1.5.9
html-template-generator 0.3.0
html-to-css 0.2.2
ide-css 0.2.0
ide-html 0.4.1
ide-php 0.6.10
ide-python 0.3.0
ide-ruby 0.1.6
ide-typescript 0.7.0
language-babel 2.79.0
linter 2.2.0
minimap 4.29.7
minimap-pigments 0.2.2
open-html-in-browser 0.2.1
pane-layout-plus 0.7.4
php-twig 4.0.0
pigments 0.40.2
react 0.17.0
todo-show 2.1.0
Huh. OK - I have not yet upgraded to high seirra. That should just open a link to https://docker.com/ . I'll leave this open until I upgrade - which should be pretty soon.
High sierra here, issue still exists.
Happens too on Linux (4.14.15-1-ARCH).
Happens when clicking on "Download docker" when it's not yet installed
~/.atom/packages/ide-ruby/src/main.js:52
ReferenceError: shell is not defined
at NotificationElement.onDidClick (~/.atom/packages/ide-ruby/src/main.js:52:56)
at HTMLAnchorElement.<anonymous> (/usr/share/atom/resources/app/node_modules/notifications/lib/notification-element.js:135:48)```
Still happening with High Sierra.
Confirmed still exists; using 10.13.4
+1 for 10.13.4, but my line numbers are slightly different:
/Users/quandary/.atom/packages/ide-ruby/src/main.js:55
ReferenceError: shell is not defined
at NotificationElement.onDidClick (/Users/quandary/.atom/packages/ide-ruby/src/main.js:55:56)
at HTMLAnchorElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/notifications/lib/notification-element.js:147:48)
No, I have them...
$ xcode-select -v
xcode-select version 2349.
@joannebasa (or anyone) - are you still having this issue? If so, I'd like to see what I can actually do to figure it out.
Can't reproduce.
I've got this error during language-ruby instalation (Windows 10)
[Enter steps to reproduce:]
- ...
- ...
Atom: 1.34.0 x64
Electron: 2.0.16
OS: Unknown Windows version
Thrown From: ide-ruby package 0.3.0
Stack Trace
Uncaught ReferenceError: shell is not defined
At C:\Users\Dasha\.atom\packages\ide-ruby\src\main.js:81
ReferenceError: shell is not defined
at NotificationElement.onDidClick (/packages/ide-ruby/src/main.js:81:60)
at HTMLAnchorElement.<anonymous> (~/AppData/Local/atom/app-1.34.0/resources/app/static/<embedded>:11:867703)
Commands
Non-Core Packages
atom-ide-ui 0.13.0
atom-runner 2.7.1
ide-ruby 0.3.0
Can you install language-ruby on its own?
Adding const { shell } = require('electron') at the top of main.js seems to fix it @kwerle it might be because require'ing help_msg.js in main might not over-require shell on some systems
Sounds promising - thanks!
Did I close this without adding that line?
Done?
Adding
const { shell } = require('electron')at the top ofmain.jsseems to fix it @kwerle it might be because require'inghelp_msg.jsin main might not over-require shell on some systems
This fixed it for me.