Does not run on jre 1.8

Question

Does not run on jre 1.8

MichaelEnke opened this issue 3 years ago · 4 comments

In DefaultLibraryLocator the method URLDecoder.decode(String, Charset) is used which is not available in 1.8.
Instead please use URLDecoder.decode(String, String) (with catching UnsupportedEncodingException).
Thank you.

Answer 1 · 2021-12-06T22:08:57.000Z

Can you give me a line number, I'm not seeing it in https://github.com/kwhat/jnativehook/blob/2.2/src/main/java/com/github/kwhat/jnativehook/DefaultLibraryLocator.java

Answer 2 · 2021-12-07T15:39:07.000Z

Oh, that report has wrong subject, sorry. Was about a change I did locally.
The problem is with Windows and space(s) in the path:
classLocation.toURI() returns file:/C:/Program%20Files/...
classLocation.getPath() returns /C:/Program%20Files/...
To fix it, please add a URLDecoder.decode(String, String) (and not URLDecoder.decode(String, Charset).

Answer 3 · 2021-12-07T15:48:12.000Z

That should have been fixed in 2.2.1, is it still a problem?

Answer 4 · 2021-12-07T16:20:57.000Z

Oh yes, sorry, I was on 2.2 branch ...