kwk/docker-registry-frontend

ENV_REGISTRY_PROXY_PORT should be optional and not default to 5000.

mohammedzee1000 opened this issue · 3 comments

Expected behaviour

  • If ENV_REGISTRY_PROXY_PORT is not provided, it should not appear in the UI.

Actual behaviour

  • The port defaults to 5000

Steps to reproduce the problem

  • Run the standard docker container, while providing ENV_REGISTRY_PROXY_FQDN, and not provide ENV_REGISTRY_PROXY_PORT

Specifications

  • 1.12
  • Fedora 25
  • v2
kwk commented

@mohammedzee1000 I was on vacation. Is the problem solved?

This is still happening, running behind Traefik:

registry-frontend:
    image: konradkleine/docker-registry-frontend:v2
    restart: always
    environment:
      ENV_DOCKER_REGISTRY_HOST: 'registry'
      ENV_DOCKER_REGISTRY_PORT: 5000
      ENV_REGISTRY_PROXY_FQDN: 'my.domain.com'

Shows in the UI as

docker pull my.domain.com:5000/image-name:latest

Not a massive issue as it can simply be fixed with:

ENV_REGISTRY_PROXY_PORT: 443