RxJS 6
ericadamski opened this issue · 15 comments
Love this repository!! Awesome package 👏
Is there a plan to update the dependencies and support RxJS 6?
Thanks, I think it'll work OOTO only except peerdep warning, but will check and try to bump peerdependency if needed.
There are a few changes like https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md#import-paths that affect the usage of 6 without the rxjs-compat package.
I guess the current solution would be to have a dev dependency of the compat. That will eventually become deprecated.
Those import paths are relevant as application, sandbox barely have imports from rx affected by it, still need to double check though. I don't consider to use compat as dep / devdep of this pkg.
I have a fork and am taking a look through the tests and upgrading the peer to 6.x.
@kwonoj I am having a little trouble running npm test | yarn test, is there something extra I have to do?
npm install / npm test should work (that's way current ci does) not sure what's missing.
Ah it seems that I needed to have the jest-cli installed globally
@kwonoj I am so sorry about bother you for all of this 😢
I have updated all the imports, tests are all 100%, I did a npm link to a package I am writing that uses only RxJS 6.x without the compat lib and it no longer throws the missing rxjs-compat error.
I am attempting to commit this using npm run commit so that I can submit a PR to you but I continue to get this error:
Am I doing something wrong, or did I break something?
Thank you for being so patient.
including jest-cli error above, I do suspect your npm installation behaves something odd. for example, any-observable is definitely dependency in lockfile https://github.com/kwonoj/rx-sandbox/blob/master/package-lock.json#L287 and it should be installed.
hum, I will do the classic rm -rf node_modules and give it another try.
That didn't work 😢
Here is the output
The only weird thing is
> weak@1.0.1 install /Users/Sgt-Wikkidoo/github/rx-sandbox/node_modules/weak
> node-gyp rebuild
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
Would it be OK to by-pass commitizen so you can pull the code?
I could just for it and publish it as rx-sandbox-6, if you don't want to move this version away from 5
Sent out 1.0.0 https://www.npmjs.com/package/rx-sandbox, appreciate for taking time to look into this.
@kwonoj anytime!