kyma-incubator/compass

Packages are not validated while creating Application with it

kfurgol opened this issue · 3 comments

kfurgol commented

Description
When you create an Application with Packages inside it, they are not validated.
Try to run that mutation:

mutation regapp {
  registerApplication(in: {
    name: "appname"
    packages: [
     {
      name: "packagename"
      apiDefinitions: [
        {
          name: "test"
          targetURL: "#$#$#$#"
        },
      ]
    },
    ]
  }) {
    name
  }
}

It shouldn't work due to invalid targetURL, but it passes.

Reasons
We need to validate Packages input.

AC

  • Packages input is validated
  • Fix tests (runtime-agent tests are failing)

Attachments
Add Packages validation here.

kyma-bot commented

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot commented

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

kyma-bot commented

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.