kypeli/kQOAuth

src/src.pro:78 incorrect for some 64-bit distros

Closed this issue · 4 comments

Some 64-bit distros use lib64 as their libdir; changing line 78 in src/src.pro to

target.path = $$[QT_INSTALL_LIBS]

will resolve the issue.

This was changed just some time ago to support Ubuntu packaging. In this merge request: smartboyhw@ad05191

I am no packaging expert, and I think the solution above is portable, but would there be any issues wrt. packaging with this change?

$$[QT_INSTALL_LIBS] should make it obey qmake's understanding of libdirs, which distros can generally handle - I actually submitted this because my distro (exherbo) has 'lib' as a symlink to 'lib64', and the package manager refuses to merge a directory over a symlink - thus, hardcoding 'lib' results in the package manager refusing to install the package.

However, setting QMAKESPEC appropriately (linux-g++-64 vs linux-g++) is pretty trivial, and is likely what most distros expect to Just Work - exherbo does it for every qmake-based package.

I too had my concerns making this change to what Ubuntu expects. So I think making this change as suggested by you makes sense. Any distro that uses Qt should know how to handle this anyway.

Solved in this commit:
36c14be