l-zeuch/yagpdb.vim

Request: Remove Modelines and Use EditorConfig

Closed this issue · 1 comments

Seeing as Vim modelines pose a security concern and are generally frowned upon, I suggest to instead resort to EditorConfig.

Reading from their documentation, everything we already do via the modelines throughout the repository is just as possible using EditorConfig. Moreover, EditorConfig allows for consistent configuration across a larger set of editors, rather than solely Vim and its derivatives.

See also https://security.stackexchange.com/questions/36001/vim-modeline-vulnerabilities for a discussion, as well as:

Although it is not impossible that these vulnerabilities are already patched, it is nonwithstanding still a good practise to abandon modelines and instead use a universal format.

Excellent point! Thanks for bringing this up