Implement auto-updates to devphase.config.json

Question

Implement auto-updates to devphase.config.json

HashWarlock opened this issue 2 years ago · 10 comments

Description

Add additional properties to the devphase.config.json and add functions to retrieve and edit the config based on different commands executed. This can help with creating/retrieving accounts, contract directory paths, networks to connect to RPCs, etc.

Swanky suite keeps track of the following in the swanky.config.json https://github.com/AstarNetwork/swanky-cli/blob/master/packages/core/src/types/index.ts#L41-L54

node: polkadot pallet version, local path, supported Ink
accounts array
contract records
network map

Swanky suite command-utils can be helpful to check as well. https://github.com/AstarNetwork/swanky-cli/blob/master/packages/core/src/lib/command-utils.ts

Devphase does have some similar functions & if we can add the missing capabilities then this enables a cleaner way to manage a Phat Contracts dev environment with commands for:

Contract
- Call
- New
- Deploy
Account
- Create
- List
Check
- Checks the package dependencies, binaries & devphase.config.json file is present

Answer 1 · 2023-01-04T20:53:25.000Z

Awesome idea. Todo

Answer 2 · 2023-01-08T11:57:01.000Z

First part:

node: polkadot pallet version, local path, supported Ink
It's already implemented in devPhaseOptions.nodeUrl and devPhaseOptions.nodeApiOptions.
https://github.com/l00k/devphase/blob/master/src/def.ts#L79
Used: https://github.com/l00k/devphase/blob/master/src/service/api/DevPhase.ts#L60
accounts array
It's already implemented in devPhaseOptions.accountsMnemonic and devPhaseOptions.accountsPaths.
https://github.com/l00k/devphase/blob/master/src/def.ts#L78
Used: https://github.com/l00k/devphase/blob/master/src/service/api/DevPhase.ts#L60
contract records
It is auto loaded based on directories.
network map
I don't know what you mean. Please describe ;)

Answer 3 · 2023-01-09T15:18:17.000Z

Account management implemented in 0.0.32

Answer 4 · 2023-01-09T18:06:48.000Z

First part:

node: polkadot pallet version, local path, supported Ink
It's already implemented in devPhaseOptions.nodeUrl and devPhaseOptions.nodeApiOptions.
https://github.com/l00k/devphase/blob/master/src/def.ts#L79
Used: https://github.com/l00k/devphase/blob/master/src/service/api/DevPhase.ts#L60

accounts array
It's already implemented in devPhaseOptions.accountsMnemonic and devPhaseOptions.accountsPaths.
https://github.com/l00k/devphase/blob/master/src/def.ts#L78
Used: https://github.com/l00k/devphase/blob/master/src/service/api/DevPhase.ts#L60

network map
I don't know what you mean. Please describe ;)

Network Map would be having a mapping of networks and the RPC URL. For instance, Phala Network, Khala Network, Phala PoC5 Testnet. Though this could be not needed.

contract records
It is auto loaded based on directories.

What does this mean? How would I need to retrieve the contract to make a call to it? I was thinking that we can be in the base directory of the project and be able to use a command like swanky has & use a command like swanky phala contract call --address <value> -m <value> [-a <value>] [-d] [-g <value>] [-n <value>]

FLAGS
  -a, --args=<value>
  -d, --dry
  -g, --gas=<value>
  -m, --message=<value>  (required)
  -n, --network=<value>  Network name to connect to
  --address=<value>      (required)

Ultimately, the idea is to be able to have a function like getSwankyConfig, so I can access all the current configuration & have functions to retrieve certain information. Here is an example https://github.com/AstarNetwork/swanky-cli/blob/26a19363938d44633e4f1e4b4fff5a363eb3984b/packages/cli/src/commands/contract/call.ts#L42

In the example, the config can retrieve contract deployment info & account info to be able to execute the contract call. There are also commands that can update the Swanky Config like the swanky contract deploy call. An example of this is here https://github.com/AstarNetwork/swanky-cli/blob/26a19363938d44633e4f1e4b4fff5a363eb3984b/packages/cli/src/commands/contract/deploy.ts#L54

Answer 5 · 2023-01-12T16:14:44.000Z

0.0.33
Configuration updated.
Network map feature implemented.
Contract commands (except call) implemented

I'm waiting for feedback at current stage

Answer 6 · 2023-01-20T02:08:12.000Z

Can there be an option to install the binaries and system contracts without starting the local testnet?
Commands like:

yarn devphase stack install
yarn devphase stack start
yarn devphase stack stop

Update dependencies for @polkadot packages

    "@polkadot/api": "9.9.1",
    "@polkadot/api-contract": "9.9.1",
    "@polkadot/keyring": "10.2.1",
    "@polkadot/util": "10.2.1",
    "@polkadot/util-crypto": "10.2.1",

My other comment would be allow for create accounts and deploy contract to accept arguments or flags instead of interactive CLI. I can make this change if needed.

Answer 7 · 2023-02-03T03:26:39.000Z

Migration to oclif finalized in 0.1.1. The rest of commands implemented in 0.1.2.
I'm waiting for your feedback.

Answer 8 · 2023-02-05T08:18:30.000Z

About dependencies check (rustup / cargo contract) - I was able to verify list of required dependencies here:
https://wiki.phala.network/en-us/build/developer/run-a-local-development-network/#environment
but now this page is not available so I don't know real dependencies.
Could you provide list?

Answer 9 · 2023-02-06T21:53:51.000Z

Phat Contract deps: https://wiki.phala.network/en-us/build/stateless/setup/
Local Tesnet deps: https://wiki.phala.network/en-us/build/advanced/run-a-local-development-network/#build-from-source

Answer 10 · 2023-02-07T11:13:25.000Z

Done, released in version v0.1.4