l3af-project/governance

Fix commit permissions

Closed this issue · 5 comments

dthaler commented

Require PR to commit, no direct checkins

And make sure CODEOWNERS and the actual permissions to merge match

dthaler commented

This is related to issue #6 which is about documenting the process for how to be a committer.
This issue on the other hand is just about enforcement and documenting the current list of committers.

jniesz commented

I added a rule to prevent direct commits and now merges are only allowed through PR with 2 approvals for the repos under L3AF project.

  • 👍4
vmbrasseur commented

Was this just flipping the bit on that setting for the org, or were teams created in the process (or some other access-defining step)?

If the latter, could we please get a list of who's allowed to do what and where?

jniesz commented

It was basically adding a branch protection rule to the repo to enforce this. Committers (write access) are the people that will have access to merge after 2 approvals.

sanfern commented

We have a CODEOWNERS file on all repositories with adequate permissions.