labmlai/annotated_deep_learning_paper_implementations

Wrong output of shift right example in the commnets?

harveyaot opened this issue · 1 comments

harveyaot commented

annotated_deep_learning_paper_implementations/labml_nn/transformers/xl/relative_mha.py

Line 28 in 9a42ac2

result would be `[[1, 2 ,3], [0, 4, 5], [9, 0, 7]]`.

this should be [[1, 2 ,3], [0, 4, 5], [6, 0, 7]]

vpj commented

Thanks! Fixed f42c0e9