Example from readme.md is broken

Question

Example from readme.md is broken

Grawl opened this issue 7 years ago · 8 comments

import dotenv from 'dotenv';
import dotenvParseVariables from 'dotenv-parse-variables';

let env = dotenv.config({});
env = dotenvParseVariables(env);

➜ gulp --tasks
[10:13:58] Requiring external module babel-register
/Users/…/Sites/…/node_modules/dotenv-parse-variables/lib/index.js:39
  if (value.toLowerCase() === 'true' || value.toLowerCase() === 'false') {
            ^

TypeError: value.toLowerCase is not a function
    at parseKey (/Users/…/Sites/…/node_modules/dotenv-parse-variables/src/index.js:30:13)
    at /Users/…/Sites/…/node_modules/dotenv-parse-variables/src/index.js:10:35
    at Array.forEach (native)
    at exports.default (/Users/…/Sites/…/node_modules/dotenv-parse-variables/src/index.js:8:20)
    at Object.<anonymous> (/Users/…/Sites/…/gulp-config.js:5:7)
    at Module._compile (module.js:569:30)
    at loader (/Users/…/Sites/…/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/…/Sites/…/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)

Answer 1 · 2017-08-04T02:58:38.000Z

I've reproduced this and working on a fix now.

Answer 2 · 2017-08-04T03:04:12.000Z

The reason why this happens is because you do not have a .env file in the directory you're running your script from. I'll update the documentation for this to catch the error, but you should definitely have a .env file...

const dotenv = require('dotenv');
const dotenvParseVariables = require('dotenv-parse-variables');

let env = dotenv.config({})
if (env.error) throw env.error;
env = dotenvParseVariables(env);

const dotenv = require('dotenv');
const dotenvParseVariables = require('dotenv-parse-variables');

let env = dotenv.config({})
+if (env.error) throw env.error;
env = dotenvParseVariables(env);

Answer 3 · 2017-08-07T13:10:55.000Z

I had the same issue with the example. The solution for me was to pass env.parsed instead of env to dotenvParseVariables. Like:

const dotenv = require('dotenv');
const dotenvParseVariables = require('dotenv-parse-variables');

let env = dotenv.config({})
if (env.error) throw env.error;
env = dotenvParseVariables(env.parsed);

Answer 4 · 2017-08-07T15:04:04.000Z

@rodw1995 this is because you're missing a .env file, no??

Answer 5 · 2017-08-07T15:13:08.000Z

@niftylettuce No, I have .env file. The variables of the file are PORT and ENABLE_HTTPS. When I load it with dotenv.config({}); the result is:

{ parsed:
   { PORT: '3000',
     ENABLE_HTTPS: '1'} }

So I need to pass env.parsed to dotenvParseVariables and then it's working!

Answer 6 · 2017-08-07T15:17:17.000Z

whats your environment / operating system btw? any other info? I can't reproduce this (on OS X)

…

On Mon, Aug 7, 2017 at 11:13 AM, Robbie op de Weegh < ***@***.***> wrote: @niftylettuce <https://github.com/niftylettuce> No, I have .env file. The variables of the file are PORT and ENABLE_HTTPS. When I load it with dotenv.config({}); the result is: { parsed: { PORT: '3000', ENABLE_HTTPS: '1'} } So I need to pass env.parsed to dotenvParseVariables and then it's working! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAf7hTbyp82OqQ3lDGPggwTcU41sNX7tks5sVymEgaJpZM4Oqc4K> .

-- @niftylettuce

Answer 7 · 2017-08-07T15:27:11.000Z

I'am working on a Windows 10 operating system. The .ENV file is in the root of the project and it's loaded from src/server.js

But it's in the dotenv docs that the result of the loaded content is in result.parsed. So I get the expected result, right?

Answer 8 · 2017-08-07T15:50:47.000Z

@rodw1995 thx for lmk, just updated the Readme + tests. I was on v2.x of dotenv with the tests, and the latest version of dotenv is v4.x, so that's why it wasn't working properly (v4.x uses env.parsed, not just env like older versions do).