lagoshny/ngx-hal-client

How to remove the dependency on CommonJS or AMD dependencies?

Closed this issue · 7 comments

Hello, is there a way to remove the dependency on CommonJS or AMD?

Warning: \node_modules@lagoshny\ngx-hal-client\fesm2015\lagoshny-ngx-hal-client.js depends on 'uri-templates'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: \node_modules@lagoshny\ngx-hal-client\fesm2015\lagoshny-ngx-hal-client.js depends on 'hash.js'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Hi @grrenier , can you try a new 1.1.7 version warnings should be gone.

If you will have some warnings please add more information about your application build system and angular version.

Hi @lagoshny , I migrated to the new version 1.1.7 but I still have the warnings. By the way, you are doing a great job on this package, it makes the job easier.

@grrenier can you tell which Angular version do you use? Do you use Angular CLI to build a project?

Hi @lagoshny , I'm using Angular 11.1.2 and Angular CLI 11.1.4

Hi @grrenier, thank you for the information.

I have published a new version where I changed CommonJS dependencies to es2015.
Try to build your project with the 1.1.9 version to check the warnings.

I updated to the new version and there are no warning. Thank you for the fix.

I have a question: How do we do the PUT, POST or PATCH of a many to many relationship replacing the objects in the JSON with URLs? If you prefer I can move this comment to another place to keep this issue clean.

Yes, it will be better to move the question about many many relationships to another issue.
I created new issue for this question.