Error with volume indicator popup
cerisezero opened this issue · 5 comments
Running 19.04. On changing the volume via keyboard controls, the icon that pops up is poorly scaled and appears completely different to that displayed using stock MATE themes - in fact, it appears to be from the Humanity theme?
This seems to be common across variants that I've tried. The stock volume control images are still in the new theme icon sets, so I'm unsure what would change here?
Modified
Stock MATE
I'll guess the file optimisation is the cause of this -- I added a last step where the generator will remove "unmodified" files and rely on icon inheritance to try and reduce the disk space for installed colour themes.
Two options:
- Disable the clean-up, so all themes contain a copy of the original Ambiant/Radiant-MATE icons.
- Adds 16.9 MB per icon theme!
- Find out the icons that need to be put back into the colour theme and make an exception along with this one.
I bet the keyboard brightness pop up would be affected too.
Unable to confirm one way or the other on the keyboard brightness, not a popup I'm familiar with. However, the laptop screen brightness popup seems to be unaffected at first glance?
It looks like might be a regression in the latest versions (19.10.10) of Ambiant/Radiant-MATE.
I just tried 19.10 in a live session with stock themes and it's showing the ugly icon.
Found the commit in the original theme, it appears these are the new icons. 😞
Add full color volume icons for use in applications and the OSD.
I've added a "patch" step so that the mono icons we like are used in the OSD.
The only potential pitfall are the applications that use a low/medium/high volume icon - but I've yet to see an app that suffers from this:
(This is from gtk3-widget-factory for testing UI controls)