Clarify `REDC` implementation (TODO comments)
Closed this issue · 1 comments
ilitteri commented
Context: P256VERIFY.yul#L240
Description:
In the REDC implementation, there are two TODO comments related to integer overflow. Both overflows can happen and must be properly handled.
The first one is tested e.g. by p256verify_wycheproof_0_should_pass.
The second one is tested e.g. by p256verify_wycheproof_115_should_pass.
Recommendation:
Remove the TODO comments.