lambdaclass/zksync_era_precompiles

Typo in referenced paper for `mixedAdditionStep` implementation

IAvecilla opened this issue · 0 comments

Context: EcPairing.yul#L1327

Description: In referenced by doc comment paper there is a typo in the addition algorithm. Coefficient which is later multiplied by yp in millerLoop should not be negated as it’s originally written in https://cryptojedi.org/papers/edate-20100614.pdf Section 5.

Recommendation:

Update doc comment fro this function explaining this typo.

zkSync:

Spearbit: