lando/lagoon

Naming lagoon projects

Opened this issue · 5 comments

pirog commented

Currently Lando will use the project in the lagoon.yml regardless of whether you've specified a different name in the Landofile or with the --name flag on init. I think we'd like to change the flow here:

  1. On lando init allow usage of the --name flag and set its default to the project of the lagoon.yml if possible
  2. If there is already a Landofile in the initialized repo with a name, use that instead of overriding it with the lagoon.project.

Notes:

  • Changing this is likely going to break all our lagoon tests so we will need to refactor them.

Probably instead of using the project from .lagoon.yml as a default, it might be better to use LAGOON_PROJECT from the docker-compose.yml - as project isn't actually required for Lagoon AFAIK?

https://github.com/amazeeio/drupal-example-simple/blob/8.x/docker-compose.yml#L16

pirog commented

Going to block this until we figure out lando/lando#2450

thom8 commented

If the --name is supplied it should overwrite project defined in .lagoon.yml, this should be the same as the project name from the lagoon API.

I could update our drush alias scripts to check for the existence of a lando project name a use this by default, that way the project in .lagoon.yml would not need to be set at all if using lando.

lando/lando#2450 (comment)

pirog commented

I'm going to keep this open but Lando will now throw an error if lagoon.project is not set, otherwise it will ensure that lando.name always matches lagoon.project

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.