langchain-ai/langchain

test(openai): increase max `test_base` max tokens

Opened this issue · 2 comments

Privileged issue

  • I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content

tests/integration_tests/chat_models/test_base.py::test_o1 is failing in CI

cc @ccurme

https://github.com/langchain-ai/langchain/blob/master/libs/partners/openai/tests/integration_tests/chat_models/test_base.py#L1019

@mdrxy Can I take this issue?

@mdrxy Is there some testing OPENAI_API_KEY that you provide to external contributors so that they can fix the issues? Please let me know if that's possible or suggest an alternative.

Also I am not facing this issue, can you confirm if this has been fixed already?

ssilare@Sahils-MacBook-Air openai % cd /Users/ssilare/Desktop/projects/langchain/libs/partners/openai && python -m pytest tests/integration_tests/chat_models/test_base.py::test_o1 -v
/Users/ssilare/.pyenv/versions/3.12.3/bin/python3: No module named pytest
ssilare@Sahils-MacBook-Air openai % uv run --group test --group test_integration pytest tests/integration_tests/chat_models/test_base.py::test_o1 -v
================================================== test session starts ==================================================
platform darwin -- Python 3.10.16, pytest-7.4.4, pluggy-1.5.0 -- /Users/ssilare/Desktop/projects/langchain/libs/partners/openai/.venv/bin/python
codspeed: 3.2.0 (disabled, mode: walltime, timer_resolution: 41.7ns)
cachedir: .pytest_cache
benchmark: 5.0.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /Users/ssilare/Desktop/projects/langchain/libs/partners/openai
configfile: pyproject.toml
plugins: asyncio-0.23.8, recording-0.13.4, benchmark-5.0.1, socket-0.7.0, cov-4.1.0, retry-1.7.0, anyio-4.8.0, codspeed-3.2.0, langsmith-0.3.45, mock-3.14.0, xdist-3.6.1, syrupy-4.8.1
asyncio: mode=auto
collected 4 items                                                                                                       

tests/integration_tests/chat_models/test_base.py::test_o1[True-False] PASSED                                      [ 25%]
tests/integration_tests/chat_models/test_base.py::test_o1[True-True] PASSED                                       [ 50%]
tests/integration_tests/chat_models/test_base.py::test_o1[False-False] PASSED                                     [ 75%]
tests/integration_tests/chat_models/test_base.py::test_o1[False-True] PASSED                                      [100%]

--------- coverage: platform darwin, python 3.10.16-final-0 ----------
Name                                            Stmts   Miss  Cover
-------------------------------------------------------------------
langchain_openai/__init__.py                        5      0   100%
langchain_openai/chat_models/__init__.py            3      0   100%
langchain_openai/chat_models/_client_utils.py      43     16    63%
langchain_openai/chat_models/_compat.py            80     56    30%
langchain_openai/chat_models/azure.py             155     81    48%
langchain_openai/chat_models/base.py             1307    865    34%
langchain_openai/embeddings/__init__.py             3      0   100%
langchain_openai/embeddings/azure.py               50     19    62%
langchain_openai/embeddings/base.py               247    168    32%
langchain_openai/llms/__init__.py                   3      0   100%
langchain_openai/llms/azure.py                     83     37    55%
langchain_openai/llms/base.py                     269    159    41%
langchain_openai/output_parsers/__init__.py         2      2     0%
langchain_openai/output_parsers/tools.py            2      2     0%
langchain_openai/tools/__init__.py                  2      0   100%
langchain_openai/tools/custom_tool.py              28     21    25%
-------------------------------------------------------------------
TOTAL                                            2282   1426    38%


================================================== slowest 5 durations ==================================================
2.17s call     tests/integration_tests/chat_models/test_base.py::test_o1[True-True]
2.11s call     tests/integration_tests/chat_models/test_base.py::test_o1[False-False]
2.10s call     tests/integration_tests/chat_models/test_base.py::test_o1[False-True]
1.90s call     tests/integration_tests/chat_models/test_base.py::test_o1[True-False]

(1 durations < 0.005s hidden.  Use -vv to show these durations.)
=================================================== 4 passed in 9.14s ===================================================
ssilare@Sahils-MacBook-Air openai %