functions return age in days when tutorial says to use months

Question

functions return age in days when tutorial says to use months

Closed this issue 6 years ago · 5 comments

https://langcog.github.io/childesr//reference/get_tokens.html

Let's use months. I might change the underlying db format because in all of our use cases I've seen days converted to months.

Answer 1 · 2017-10-21T20:27:01.000Z

Months are not a thing though! A month is not a scientific unit. That’s why the underlying architecture needs to be days.

Answer 2 · 2017-10-21T20:37:11.000Z

True. Although working with the original "3;4" age encodings is the underlying problem I suppose. I'll keep age in days in the db. As for the interface, do you think users should be searching by days or months? They'll be doing things like 18*30 or 18*30.5, which also seems undesirable

Answer 3 · 2017-10-22T12:57:07.000Z

I think in the interface we still want to use months. not sure what the right choice is on the backend. We could have a month column as well. That's redundant, but maybe clear?

Answer 4 · 2017-10-23T06:30:14.000Z

Yeah. Another thought is to just always convert days to months when returning data to the user

Answer 5 · 2017-10-26T18:51:47.000Z

ok, consensus - days on the backend, months on the frontend. make sure to use the correct conversion (including leap years but not on the 100 year etc.)