unable to retrieve all tokens from a child
Closed this issue · 3 comments
amsan7 commented
get_tokens
has no default when token
param isn't specified
dyurovsky commented
Good point. We decided not to let people search for all tokens because it takes too long, but maybe we should allow this within child or corpus? What do you think @mikabr ?
mcfrank commented
How about if we throw an error ("that'll take too long! confirm that you
want *all* the tokens by supplying * as the token specifier.")
Mike
…On Wed, Sep 20, 2017 at 5:17 AM, Dan Yurovsky ***@***.***> wrote:
Good point. We decided not to let people search for all tokens because it
takes too long, but maybe we should allow this within child or corpus? What
do you think @mikabr <https://github.com/mikabr> ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABGul3x_7H9zgoObwdoVAjJEKtK12SEOks5skQJtgaJpZM4PdonT>
.
mikabr commented
I agree with Mike, how about something like Error: Argument "token" is missing. To fetch all tokens, supply "*" for argument "token". Caution: this may result in a long-running query.