Add end() method to spans and generations
Closed this issue · 4 comments
maxdeichmann commented
Users want to be able to quickly end
spans and generations.
generation = langfuse.generation(...)
generation.end()
- For
StatefulGenerationClient
andStatefulSpanClient
, addend()
methods, sendendTime
to the Langfuse server. Under the hood, they can use the existingupdate
functions. - Create test coverage for both of the functions
marcklingen commented
Should this method still accept the update body excluding the endTime (optionally)?
maxdeichmann commented
Should this method still accept the update body excluding the endTime (optionally)?
You mean it should take an object that takes everything except the endTime? Sure, we can do this.
Dev-Khant commented
@marcklingen @maxdeichmann This function is added!
Dev-Khant commented
It can be closed now @maxdeichmann