Unable to use $this->execute inside an artisan command

Question

Unable to use $this->execute inside an artisan command

Closed this issue 10 years ago · 15 comments

Hi,
i'm trying to use the CommanderTrait inside an artisan command, but i receive the following error:
{"error":{"type":"ErrorException","message":"Declaration of Laracasts\\Commander\\CommanderTrait::execute() should be compatible with Illuminate\\Console\\Command::execute(Symfony\\Component\\Console\\Input\\InputInterface $input, Symfony\\Component\\Console\\Output\\OutputInterface $output)","file":"\/Users\/lucacri\/Sites\/YodaImporter\/app\/commands\/ReassignVncPorts.php","line":77}}

From what i can see, the Illuminate\Console\Command has already an execute method in line 110:
protected function execute(InputInterface $input, OutputInterface $output)

and it's not working well with the CommanderTrait. Any suggestion on how to fix it?

Answer 1 · 2014-08-06T22:59:00.000Z

That's because the command class you're extending already has an execute method. So, when you pull in the trait, they're clashing.

Answer 2 · 2014-08-07T16:08:50.000Z

I know, I figured it out after a bit of head-scratching :-)

I know it would break backwards-compatibility to change the method name, so I guess we can either close it or maybe create a wrapper trait for artisan commands. I used this package in all my CLI commands and it makes a lot of sense (CLI and Web are both external facing parts of the app). What do you think?

Answer 3 · 2014-08-17T00:28:43.000Z

Maybe a more explicit executeCommand function name would be more semantic anyways?

Answer 4 · 2014-08-19T05:44:53.000Z

+1 - It wouldn't be backwards compatible, but I also think 'executeCommand' would be a better method name

Answer 5 · 2014-08-19T05:46:16.000Z

Does anyone know of a way around it without modifying the CommanderTrait?

Answer 6 · 2014-08-19T15:32:32.000Z

@samwalshnz @laracasts @lucacri

http://www.sitepoint.com/using-traits-in-php-5-4/

Use the alias.

use Commander {
    Commander::execute as executeCommand
}

(its bad, but if you want to avoid extend/modify the existing commander, its a solution)

Answer 7 · 2014-08-19T21:30:38.000Z

Oh man! You learn something every day. Thank you @stevenklar!

Answer 8 · 2014-08-19T21:31:58.000Z

wow. Really nice reference.

Answer 9 · 2014-08-27T11:21:58.000Z

@stevenklar ... I'm still getting the same error. Can you paste a code that works?

Answer 10 · 2014-09-10T21:14:42.000Z

use Commander { executeCommand insteadof Commander::execute } should be possible too (according to the link provided above).

Answer 11 · 2014-09-22T16:08:20.000Z

Unable to use the alias also...

Answer 12 · 2014-09-25T02:13:33.000Z

@JeffreyWay, not sure if this means this issue should be reopened or not, but I've just tried to use the code examples @juukie14 and @stevenklar have recommended with no success.

Answer 13 · 2014-10-17T20:22:46.000Z

I am having the same issue with the conflicts too

Answer 14 · 2015-01-14T21:54:21.000Z

Has anyone solved this?

Answer 15 · 2015-01-14T22:26:29.000Z

See https://laracasts.com/discuss/channels/general-discussion/laracasts-commander-with-artisan-commands

I used the answer given there but don't use the Trait.