laravel-enso/core

Framework doesn't handle multi-level menu well

jlsjonas opened this issue · 4 comments

jlsjonas commented

This is a bug.

Prerequisites

  • Are you running the latest version?
  • Are you reporting to the correct repository?
  • Did you check the documentation?
  • Did you perform a cursory search?

Description

image
adding a 2nd menu level breaks url changes, and (likely related/the cause) can't seem to find the correct action state on the 2nd item
image

Breadcrumbs do work, and the navigation does happen (though gets reverted on page refresh)

Steps to Reproduce

  1. Add a has_children menu entry to laravel-enso.com with as parent another has_children item
  2. move/create a menu inside the newly created entry
  3. navigate to it, notice the above

Expected behavior

same behavior as single-level items

Actual behavior

errors

aocneanu commented

the problem is exactly the next line where commit is not passed recursively.
(updateActiveMenu(menu.children, commit))

I'm working on the new release now and this will be fixed as well

  • 👍1
jlsjonas commented

Oh wauw... I looked everywhere where it wasn't passed along... except within itself 😅

Thanks!

aocneanu commented

laravel-enso/menus@b23989f is related, the params returned by MenuController@store were also wrong

  • 👍1
aocneanu commented

fixed in the new core.

  • 🎉1