laravel/lumen-framework

Use Illuminate router instead of fast router

Stevemoretz opened this issue · 4 comments

This could be very useful as an option to use Illuminate router instead, fast router the syntax is different the bindings are not really good.

I am familiar with concept and even tried to change it myself, $app->router =.... but it gives an error when it wants to fetch the routes, I made the syntax compatible but using Illuminate router internally and override the getRoutes to return fast router format, but the route bindings are a real pain.

Here's how this can be used without laravel
https://github.com/mattstauffer/Torch/tree/master/components/routing

So please explain a little how can I do change it myself if you don't like this feature to be implemented.

If you are interested in a PR to implement this please let me know as well.

Why not just use Laravel?

Once you have the Laravel router, Lumen is no faster, if not slower. ;)

Why not just use Laravel?

Because I'm using it in combination with WordPress and having laravel installed alongside WordPress sounds like too much overhead, doesn't it? It has a lot of stuff about views blades react and Vue support and a lot more, which I don't clearly need.

Once you have the Laravel router, Lumen is no faster, if not slower. ;)

LOL, why would it be slower? It has a lot less to offer so it still be faster won't it?

I don't know how much is the difference in speed, would you mind give an example? I don't think it's really that much.

If it's not that much we're just losing convince, and getting inconsistenty.

For instance some libraries provide routing, which will fail because of this and we can't use those libraries.

Again it is inconsistent so if you wanna migrate from lumen to laravel, it becomes cumbersome to convert all these.

So even if it makes it 100ms slower I'm willing to do it, and it guess a lot of other people do too.

Use Laravel if you need this.