laravel/nova-issues

Inconsistent name of breadcrumbs method in controllers

JanuszSmola opened this issue · 2 comments

JanuszSmola commented
  • Laravel Version: 11.5.0
  • Nova Version: 4.33.3
  • PHP Version: 8.3.7

Description:

Every single controller which generates breadcrumbs uses breadcrumbs method to generate it except one. \Laravel\Nova\Http\Controllers\Pages\ResourceUpdateController is using breadcrumb as a method name. For consistency reasons I think it would be nice to change it to breadcrumbs (with "s", as in other controllers). It will also help overriding this method.

So I suggest change:
protected function breadcrumb(ResourceUpdateOrUpdateAttachedRequest $request)
to:
protected function breadcrumbs(ResourceUpdateOrUpdateAttachedRequest $request)

crynobone commented

Will be part of Nova 5 release

github-actions commented

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.