laravel/tinker

Tinker lost colors

Jervi-sir opened this issue · 18 comments

Jervi-sir commented
  • Tinker Version: 2.6.1
  • Laravel Version: 8.47.0
  • PHP Version: 8.0.7
  • Psy Shell: v0.10.8
  • Database Driver & Version:

Description:

Tinker is not using colors, all the text is white only, this issue happened when I installed a latest version of Laravel ( 8.47.0 ),
I went to try some oldest versions of Laravel ( 8.46.0 and older ) tinker worked fine, text was colored fine,
what should we do?

Steps To Reproduce The Issue:

It happens whenever we create a fresh Laravel project with composer

composer create-project laravel/laravel .

Samples

cmd

cmder

driesvints commented

Please provide a way for us to reproduce this.

bobthecow commented

Which PsySH version is working for you, and which is not?

Jervi-sir commented

@driesvints, for me it happens when ever I create a fresh Laravel project via composer,
my excuses for not providing more info

Jervi-sir commented

@bobthecow, so far Psy Shell v0.10.8, I edited the report, please check it

  • 👍1
bobthecow commented

What does running psy\info() inside tinker output in both cases?

  • ❤️1
driesvints commented

@bobthecow thanks for helping out here 👍

  • 👍1
Jervi-sir commented

@bobthecow,, want to update you,
I found a file in "vendor/psy/psysh/src/configuration.php" where a line was

const COLOR_MODE_DISABLED = 'disabled';

is it a good way to turn it into 'auto' too

  • 👍4
bobthecow commented

I believe this issue is symfony/symfony#41723, though not for any of the reasons already listed on that issue.

PsySH (and thus Tinker) treats --ansi / --no-ansi as a three-state pair of options: either you specify explicitly that you want color, or explicitly don't, or the app decides for you.

As of the latest Symfony, the built-in --ansi option is defined as "negatable". So if you don't explicitly specify --ansi, it acts like you've implicitly specified --no-ansi. So when PsySH tries to figure out whether you want color or not, the latest Symfony lies and says you don't.

One additional complication, though: Symfony Console, itself, doesn't parse those options that way, despite defining them that way. So I'm pretty convinced this is a bug in the default --ansi option definition, and we shouldn't be using negatable like this.

Anyway, it looks like that change will be reverted until Symfony 6.0 because it also caused backwards compatibility breaks (as it did for us), so we can fight that fight later 😛

In the meantime, specifying --color or --ansi to force the color on should work!

  • 🚀5
driesvints commented

Seems like this is also a result of symfony/symfony#39642? Anyway, thanks for investigating this @bobthecow.

GrahamCampbell commented

Cool. So this will be fixed in the next round of patch releases to the symfony console component?

driesvints commented

@GrahamCampbell the PR @bobthecow linked to isn't merged yet.

niladam commented

Since this is now closed, while i personally think it should be open while we keep track of it and until it gets fixed here's a simple quickfix for people encountering this. Simply run tinker like this:

php artisan tinker --ansi - this forces the color output :)

  • 👍26
  • ❤️14
codecapsules commented

@bobthecow,, want to update you,
I found a file in "vendor/psy/psysh/src/configuration.php" where a line was

const COLOR_MODE_DISABLED = 'disabled';

is it a good way to turn it into 'auto' too

Thanks work like a charm !

bobthecow commented

Wait, are you saying you edited that file in your vendor folder?

boyet007 commented

it works @niladam
Thank you

  • 👍1
tiagofrancafernandes commented

@bobthecow,, want to update you, I found a file in "vendor/psy/psysh/src/configuration.php" where a line was

const COLOR_MODE_DISABLED = 'disabled';

is it a good way to turn it into 'auto' too

Thanks! Some change now (2021)

vendor/psy/psysh/src/Configuration.php:37