laravelio/laravel.io

Open external links in new tab and add utm parameters + Rename twitter to X

Closed this issue ยท 5 comments

This is not an issue per say but an enhancement that I would like to contribute and before working on a PR wanted feedback from the maintainers.

External links when clicked upon redirect the user away from the site. It would be nice to open these links in new tab and add utm source parameters.
Example: Pastebin, Chat, Community and Social links in header, footer, user profile etc

Using X instead of twitter. Twitter word is being used in profile, socials etc.

@driesvints Please let me know what you think

Heya, in general I'm not a fan of adding target="_blank" to links as I think it should be a user choice to open these in a new tab.

What would the benefit for us be to add the utm source params?

Afaik we already use X everywhere?

Heya, in general I'm not a fan of adding target="_blank" to links as I think it should be a user choice to open these in a new tab.

Makes sense ๐Ÿ‘

What would the benefit for us be to add the utm_source params?

For social and chat links no benefit as such but for community links and paste bin link it can be helpful for analytics

Afaik we already use X everywhere?

Not everywhere, here are some screenshots:
image
image
image

Maybe change the X Twitter naming to "X (Twitter)" and the direct links to x.com indeed ๐Ÿ‘

Hi @driesvints
I have sent a PR #1170 for this.

Also I noticed that form labels display the name attribute in the slot rather than what's in the slot.
Screenshot 2024-11-02 at 12 08 30
image
The label should be X (Twitter) handle rather than Twitter. Is it intentional or it's a bug?

I fixed the label bug in Blade UI Kit itself.